Handle tarballs with dev.eessi.io project subdir in name#212
Merged
bedroge merged 6 commits intoEESSI:mainfrom Apr 17, 2025
Merged
Handle tarballs with dev.eessi.io project subdir in name#212bedroge merged 6 commits intoEESSI:mainfrom
dev.eessi.io project subdir in name#212bedroge merged 6 commits intoEESSI:mainfrom
Conversation
bedroge
reviewed
Apr 15, 2025
Comment on lines
+261
to
+262
| # Handle longer prefix with project name in dev.eessi.io and | ||
| # get |
Collaborator
There was a problem hiding this comment.
and get... the right basedir? 😄
Member
Author
There was a problem hiding this comment.
🤦 😅 , I didn't push the latest commit
Member
Author
|
One tarball was created, waiting for two more. We can test we just one, if so, adding the |
bedroge
reviewed
Apr 17, 2025
Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
bedroge
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The software-layer PR (link incoming) for support for
dev.eessi.iobuilds encodes the subdir name in the tarball. Because the file tree has a different depth and the position of the project subdirectory in the tree moved, this also had to be adjusted. This PR handles these changes and should not impact other builds forsoftware.eessi.io.